This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/testsuite] Cleanup pending breakpoints
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Wed, 24 Apr 2013 15:35:27 +0100
- Subject: Re: [RFA/testsuite] Cleanup pending breakpoints
- References: <517716B5 dot 7050406 at redhat dot com>
On 04/24/2013 12:18 AM, Keith Seitz wrote:
> Hi,
>
> Some types of pending breakpoints are commonly set by using gdb_test_multiple to respond to the "Make breakpoint pending?" question. This patch adds support for several breakpoint types to gdb_breakpoint so that the standard machinery can be used instead.
>
> I've also taken this opportunity to update the neglected documentation for gdb_breakpoint. AFAICT, "passfail" just appeared out of nowhere, and it has never been implemented/documented.
Whenever you feel compelled to say "also" in a patch description,
consider splitting the patch in two. ;-) Updating the documentation
part could go first, and would be clearly an improvement. Extending
the interface could go afterwards, and that patch would then actually
be clearer.
>
> Comments/questions?
I wonder whether "allow-pending" is the right option for the "pending" tests.
As in, "allow" != "require". I wonder whether we're losing test
coverage in those cases?
--
Pedro Alves