This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] add -s option to make -break-insert support dprintf
- From: Hui Zhu <teawater at gmail dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: tromey at redhat dot com, palves at redhat dot com, hui_zhu at mentor dot com, gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Mon, 20 May 2013 15:30:44 +0800
- Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
- References: <515451EA dot 1000200 at mentor dot com> <83y5d7wpvq dot fsf at gnu dot org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q at mail dot gmail dot com> <516454DA dot 9040109 at redhat dot com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig at mail dot gmail dot com> <87ppxzhfqy dot fsf at fleche dot redhat dot com> <CANFwon2_yT4SOpK7=Rq=91nFcvk2Rn3_wAkCMmsfgP-6iynGig at mail dot gmail dot com> <516C2549 dot 3060808 at redhat dot com> <CANFwon0WYLZEKWkfHzRgCB8MOPPoCsDvSaCk0SSYXPgonuE5zw at mail dot gmail dot com> <87vc7ithtj dot fsf at fleche dot redhat dot com> <CANFwon0jwdrDULV+bPRX_5AWE2tgq=rSrA6eyZEujZqPfN+Huw at mail dot gmail dot com> <87wqrrll9m dot fsf at fleche dot redhat dot com> <CANFwon3yyKxMVRO3wJ3=VTDLpege_NWByMA9-jk_g9_a5mXaoQ at mail dot gmail dot com> <87d2t2tt02 dot fsf at fleche dot redhat dot com> <CANFwon3meTbHqy-kfibR6XiJpkZdS3348am2wP6i9Dbz_sowLg at mail dot gmail dot com> <87ehdehnc9 dot fsf at fleche dot redhat dot com> <CANFwon0NgSTcX+iuPsSPWU_t6O1UebETRrGvG7ghcAwC-MXTRA at mail dot gmail dot com> <838v3masbd dot fsf at gnu dot org> <CANFwon0cXTz+X2A_3Fz1kuc40H64siGYGtO6CRKyGeMw88ca2Q at mail dot gmail dot com> <834ne6an8h dot fsf at gnu dot org> <CANFwon0fMc6efTtEVn_WLQ+8EaCzQ6f2AJH22jPg1RHyhnM2eg at mail dot gmail dot com>
Ping http://sourceware.org/ml/gdb-patches/2013-05/msg00460.html
Thanks,
Hui
On Tue, May 14, 2013 at 12:56 PM, Hui Zhu <teawater@gmail.com> wrote:
> On Mon, May 13, 2013 at 11:55 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>>> From: Hui Zhu <teawater@gmail.com>
>>> Date: Mon, 13 May 2013 11:38:40 +0800
>>> Cc: tromey@redhat.com, palves@redhat.com, hui_zhu@mentor.com,
>>> gdb-patches@sourceware.org, marc.khouzam@ericsson.com
>>>
>>> >> +If @var{location} cannot be parsed (for example if it
>>> > ^
>>> > A comma is missing.
>>>
>>> The comma is after the right parenthesis: refers to unknown files or functions),
>>> Do I need change this part to following format?
>>> If @var{location} cannot be parsed, (for example if it
>>> refers to unknown files or functions) create a pending
>>
>> No, I meant the comma after "for example", inside the parentheses.
>
> Fixed.
>
> Post a new version for it.
>
> Thanks,
> Hui
>
> 2013-05-14 Hui Zhu <hui@codesourcery.com>
>
> * breakpoint.c (dprintf_breakpoint_ops): Remove its static.
> * breakpoint.h (dprintf_breakpoint_ops): Add extern.
> * mi/mi-cmd-break.c (ctype.h): New include.
> (gdb_obstack.h): New include.
> (mi_argv_to_format, mi_cmd_break_insert_1): New.
> (mi_cmd_break_insert): Call mi_cmd_break_insert_1.
> (mi_cmd_dprintf_insert): New.
> * mi/mi-cmds.c (mi_cmds): Add "dprintf-insert".
> * mi/mi-cmds.h (mi_cmd_dprintf_insert): New extern.
>
> 2013-05-14 Hui Zhu <hui@codesourcery.com>
>
> * gdb.texinfo (GDB/MI Breakpoint Commands): Describe the
> "-dprintf-insert" command.
>
> 2013-05-14 Hui Zhu <hui@codesourcery.com>
>
> * gdb.mi/Makefile.in (PROGS): Add "mi-dprintf".
> * gdb.mi/mi-dprintf.exp, gdb.mi/mi-dprintf.c: New.