This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Revised display-linkage-name


Ping!

On 05/22/2013 11:03 AM, Michael Eager wrote:
Attached is a revised patch to display the linkage name (the linker symbol)
along with the function name when setting, listing, or hitting a breakpoint.
This is a revision of http://sourceware.org/ml/gdb-patches/2013-03/msg00806.html.
(BTW, the gdb-patches mailing list archive doesn't show the original email from
3/18/13, quoted in the referenced message.)

Changes:
   Add NEWS and docs.
   Add linkage name to "info break" listing.
   Add MI annotations.
   Add command to set/show display length limit, remove define.
   Add test case.

There is a minor inconsistency where the linkage name is displayed.
When setting/hitting a breakpoint, the linkage name is displayed
within brackets following the source name, before the arguments.  In
the "info breakpoint" command, the linkage name is displayed in brackets
after the arguments.  This is because SYMBOL_PRINT_NAME(sym) returns a
complete function signature, not just the function name.

The test case was added to gdb.cp for convenience, since it uses
the C++ compiler.  The patch is not dependent on C++.

Tom -- can you verify that the MI support is correct?   I don't have
any way to test this.


gdb/
2013-05-23  Michael Eager <eager@eagercon.com>

       * NEWS: Announcement.
       * ada-lang.c: Update calls to find_frame_funname.
       * disasm.c: Likewise.
       * python/py-frame.c: Likewise.
       * annotate.c (annotate_linkage_name): New.
       * annotate.h (annotate_linkage_name): Declare.
       * breakpoint.c (print_breakpoint_location): Print linkage name.
       * defs.h (build_address_symbolic): Add linkname arg.
       * printcmd.c (print_address_symbolic): Print linkage name.
       (build_address_symbolic): Return linkage name.
       * stack.c (find_frame_funname): Return linkage name.
       (print_frame): Print linkage name.
       * stack.h (find_frame_funname): Update declaration.
       * top.c (display_linkage_name, display_linkage_name_len): New.
       (show_display_linkage_name, show_display_linkage_name_len): New cmds.
       * top.h (display_linkage_name, display_linkage_name_len): Declare.

gdb/doc
2013-05-23  Michael Eager <eager@eagercon.com>

       * gdb.texinfo: Add description.

gdb/testsuite
2013-05-23  Michael Eager <eager@eagercon.com>

       * gdb.cp/display-linkage-name.exp: New.
       * gdb.cp/display-linkage-name.cc: New.



--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]