This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch/Darwin] Fix cleanup leak in machoread.c:macho_symfile_read
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org, Tristan Gingold <gingold at adacore dot com>
- Date: Tue, 18 Jun 2013 09:41:54 -0600
- Subject: Re: [patch/Darwin] Fix cleanup leak in machoread.c:macho_symfile_read
- References: <20130604133005 dot GE12363 at adacore dot com> <1370942792-734-1-git-send-email-brobecker at adacore dot com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> This patch prevents this by using one single cleanup queue for
Joel> the entire function, rather than having additional separate
Joel> cleanup queues (Eg: for the handling of the minimal symbols),
Joel> thus preventing the premature free'ing of the minimal_symbols
Joel> array.
Joel> Secondly, this patch takes this opportunity for avoiding the use
Joel> of the oso_vector global, thus making it simpler to track its
Joel> lifetime.
Thanks for doing this, Joel.
Tom