This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] don't keep a gdb-specific date


On 06/19/2013 07:13 PM, Tom Tromey wrote:
>  
> -version.c: Makefile version.in
> -	rm -f version.c-tmp version.c
> +version.c: Makefile version.in $(srcdir)/../bfd/version.h
> +	rm -f version.c-tmp version.c version.tmp
> +	date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../bfd/version.h`; \
> +	sed -e "s/DATE/$$date/" < $(srcdir)/version.in > version.tmp
>  	echo '#include "version.h"' >> version.c-tmp
> -	echo 'const char version[] = "'"`sed q ${srcdir}/version.in`"'";' >> version.c-tmp
> +	echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
>  	echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
>  	echo 'const char target_name[] = "$(target_alias)";' >> version.c-tmp
>  	mv version.c-tmp version.c
> +	rm -f version.tmp
>  
>  observer.h: observer.sh doc/observer.texi
>  	${srcdir}/observer.sh h ${srcdir}/doc/observer.texi observer.h
> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in
> index e8470a8..067302d 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -389,12 +389,15 @@ am--refresh:
>  
>  force:
>  
> -version.c: Makefile $(srcdir)/../version.in
> -	rm -f version.c-tmp version.c
> +version.c: Makefile $(srcdir)/../version.in $(srcdir)/../../bfd/version.h
> +	rm -f version.c-tmp version.c version.tmp
> +	date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$$/\1/p' $(srcdir)/../../bfd/version.h`; \
> +	sed -e "s/DATE/$$date/" < $(srcdir)/../version.in > version.tmp
>  	echo '#include "server.h"' >> version.c-tmp
> -	echo 'const char version[] = "'"`sed q ${srcdir}/../version.in`"'";' >> version.c-tmp
> +	echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
>  	echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
>  	mv version.c-tmp version.c
> +	rm -f version.tmp
>  version.o: version.c $(server_h)

Looks fine now, thanks.

How about we move version.* to common/ ?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]