This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- From: Doug Evans <dje at google dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: Yao Qi <yao at codesourcery dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Mon, 24 Jun 2013 12:03:40 -0700
- Subject: Re: [PATCH] print '--with{,out}-babeltrace' in 'gdb --configuration'
- References: <1365761475-23845-1-git-send-email-yao at codesourcery dot com> <CADPb22RPtCiBOg8o6M1vKXJxGeDcTOriact4ujojygskBnrFFQ at mail dot gmail dot com> <83fvyr58c5 dot fsf at gnu dot org> <CADPb22R_D10GWjkpBMag2+kDXbzCrpxjmR8UF_AZ13J6tix84g at mail dot gmail dot com> <516DEDAD dot 8070902 at codesourcery dot com> <CADPb22TtrdbFERAV_MZhvE43XVJuB25RwUgBVUwPVBEcGObLgg at mail dot gmail dot com> <516E0ED2 dot 2080203 at codesourcery dot com> <83obdd2irl dot fsf at gnu dot org> <CADPb22RcDd7LyyTL=TWpkxFS+s6hx+_xRL-_+iiWgZG0qRu=VA at mail dot gmail dot com> <83sj0al6u1 dot fsf at gnu dot org> <CADPb22T+_CC13O9PSR-STBTuCzbf7QE2BHXUPB=9KiFwDKGVvA at mail dot gmail dot com> <834ncnjqmg dot fsf at gnu dot org>
On Mon, Jun 24, 2013 at 11:44 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Mon, 24 Jun 2013 11:35:31 -0700
>> From: Doug Evans <dje@google.com>
>> Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
>>
>> > diff -u -p -r1.236 top.c
>> > --- gdb/top.c 30 May 2013 17:27:44 -0000 1.236
>> > +++ gdb/top.c 22 Jun 2013 11:30:47 -0000
>> > @@ -1252,6 +1252,9 @@ This GDB was configured as follows:\n\
>> > --without-babeltrace\n\
>> > "));
>> > #endif
>> > + fprintf_filtered (stream, _("\n\
>> > + (\"Relocatable\" means directory can be moved with the GDB installation tree.)\n\
>> > +"));
>> > }
>>
>> If you want to print something here, then I think you need to take
>> into account whether "relocatable" is printed at all.
>
> I don't think it's a real danger. One must invest a non-trivial
> effort to have GDB configured without a single relocatable directory.
Ok, How about:
+ /* We assume "relocatable" will be printed at least once, thus we always
+ print this text. It's a reasonably safe assumption for now. */
+ fprintf_filtered (stream, _("\n\
+ (\"Relocatable\" means the directory can be moved with the GDB installation"
"tree and GDB will still find it.)\n\"
+"));
[N.B. I didn't verify 80-column-ness, leaving that to you if you like
the wording.]
>> How about just a sentence or two in the manual near the description of
>> --configuration (or some such).
>
> I tried that, but found no good place to say that. Just saying
> something where --configuration is described will get this lost in the
> humongous manual, and users will not necessarily know where to look.
"relocatable" doesn't appear that many times in the manual.
"(relocatable)" doesn't currently appear at all.
If a user can't find it I'm not worried about claims it's the manual's fault.
Having this text is not important to me though, so feel free to drop it.