This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Apply fix to 15519 to 7.6 branch
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Jun 2013 12:33:35 -0700
- Subject: Re: [RFA] Apply fix to 15519 to 7.6 branch
- References: <yjt261x3iasf dot fsf at ruffy dot mtv dot corp dot google dot com>
> I'd like to apply this to the 7.6 branch.
> Regression tested on amd64-linux, with/without Fission.
>
> Ok to check in?
>
> 2013-06-06 Doug Evans <dje@google.com>
>
> * gdb.cp/derivation.exp: Make tests have unique names.
>
> 2013-06-05 Doug Evans <dje@google.com>
> Keith Seitz <keiths@redhat.com>
>
> PR 15519
> * cp-namespace.c (find_symbol_in_baseclass): Call
> cp_lookup_symbol_in_namespace instead of cp_lookup_symbol_namespace.
> Check result of call to lookup_symbol_static.
> Call lookup_static_symbol_aux unconditionally.
> Call check_typedef on base types before accessing them.
> (cp_lookup_nested_symbol): Fix comment.
>
> testsuite/
> * gdb.cp/derivation2.cc: New file.
> * gdb.cp/derivation.cc (main): Call foo2.
> * gdb.cp/derivation.exp: Add tests for typedefs in another
> file, and when there's an active block.
Of course. You are much better qualified than I am to determine
the benefit / risk, so feel free to make those decisions (I think
that, for this area, Tom might be a good resource as well).
Just a quick reminder to update the release wiki page (I see you
already have a PR, which is going to make it less work :-) ).
Thank you!
--
Joel