This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA 4/5] New port: CR16: gdbserver
- From: Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 26 Jun 2013 07:08:07 +0000
- Subject: RE: [RFA 4/5] New port: CR16: gdbserver
- References: <C6CA53A2A46BA7469348BDBD663AB65845B2FF84 at KCHJEXMB03 dot kpit dot com> <50CB742E dot 9090506 at redhat dot com> <C6CA53A2A46BA7469348BDBD663AB65848564536 at KCHJEXMB02 dot kpit dot com> <50F97ABF dot 4060203 at redhat dot com> <C6CA53A2A46BA7469348BDBD663AB65848577553 at KCHJEXMB02 dot kpit <50FEAAB2 dot 9090903 at redhat dot com> <C6CA53A2A46BA7469348BDBD663AB65848578991 at KCHJEXMB02 dot kpit dot com> <50FFE596 dot 20303 at redhat dot com> <C6CA53A2A46BA7469348BDBD663AB65848578A02 at KCHJEXMB02 dot kpit dot com> <50FFF730 dot 9050108 at redhat dot com> <C6CA53A2A46BA7469348BDBD663AB6585308FA32 at KCHJEXMB02 dot kpit dot com> <51C9E48B dot 7050605 at redhat dot com>
>> I'm not clear on point #2, but the rest sounds excellent. Thanks!
Thanks for the review and kind words.
I have tried to answer point #2 in my gdb port reply. I may add the "r0r1_orig"
register into the port to support system restarting similar to other ports.
>> Add empty line between describing comment and function definition.
I will run through the code again and fix up the formatting.
Thanks,
Kaushik