This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] gdbserver: fix the standalone build
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Mircea Gherzan <mircea dot gherzan at intel dot com>, tromey at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 28 Jun 2013 13:22:59 +0100
- Subject: Re: [PATCH v3] gdbserver: fix the standalone build
- References: <1372420771-942-1-git-send-email-mircea dot gherzan at intel dot com> <51CD7ED4 dot 6070104 at codesourcery dot com>
On 06/28/2013 01:17 PM, Yao Qi wrote:
> On 06/28/2013 07:59 PM, Mircea Gherzan wrote:
>> When directly invoking gdb/gdbserver/configure && make, the build will
>> fail because the $(host_alias) is empty and thus create-version.sh does
>> not get enough parameters.
>>
>> The output of gdbserver --version without this patch (built like above):
>>
>> [...]
>> This gdbserver was configured as ""
>>
>> After applying this patch:
>>
>> [...]
>> This gdbserver was configured as "x86_64-unknown-linux-gnu"
>>
>> Ok to commit?
>>
>> 2013-06-28 Mircea Gherzan<mircea.gherzan@intel.com>
>>
>> gdbserver:
>>
>> * configure.ac (version_host): Add it.
>> (version_host): Add it.
>> * configure: Rebuild.
>> * Makefile.in (version_host): Add it.
>> (version_target): Add it.
>> (version.c): Use $(version_host) and $(version_target).
>
> If we commit this patch, probably my patch to common/create-version.sh
> becomes useless, because 'target_alias' or 'target' will be always
> passed to it.
>
> 2013-06-27 Yao Qi <yao@codesourcery.com>
>
> * common/create-version.sh: Update comments. Handle the case
> that TARGET_ALIAS is empty.
>
> revert it?
Doesn't GDB, and whatever other users of create-version.h, need the
same treatment first?
--
Pedro Alves