This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH, testsuite] Fix failures in gdb.mi/gdb2549.exp when register 0 doesn't have a name
- From: Luis Machado <lgustavo at codesourcery dot com>
- To: "'gdb-patches at sourceware dot org'" <gdb-patches at sourceware dot org>
- Date: Fri, 28 Jun 2013 16:34:55 -0300
- Subject: [PATCH, testsuite] Fix failures in gdb.mi/gdb2549.exp when register 0 doesn't have a name
- Reply-to: lgustavo at codesourcery dot com
Hi,
This testcase only checks for the correct printing of registers via the
mi command -data-list-register-values, not paying attention to register
values, numbers or anything else.
Things work fine for targets that have register number 0 with a
non-empty name. For other targets where register number 0 has an empty
name, things break. As examples, we have a number of MIPS targets.
Such breakage happens because the logic for -data-list-register-values
skips registers with empty names and proceeds to print the next register.
As an outcome, we start printing registers with numbers above 0, which
is not something this testcase expects.
The following patch fixes this by completely ignoring the register
number field.
Ok?
Luis
2013-06-28 Luis Machado <lgustavo@codesourcery.com>
* gdb.mi/gdb2549.exp (register_tests): Expect any decimal for the
register number instead of expecting only 0.
diff --git a/gdb/testsuite/gdb.mi/gdb2549.exp b/gdb/testsuite/gdb.mi/gdb2549.exp
index 5c1fede..597d098 100644
--- a/gdb/testsuite/gdb.mi/gdb2549.exp
+++ b/gdb/testsuite/gdb.mi/gdb2549.exp
@@ -56,23 +56,23 @@ proc register_tests { } {
set float "\\-?((\[0-9\]+(\\.\[0-9\]+)?(e\[-+\]\[0-9\]+)?)|(nan\\($hex\\)))"
mi_gdb_test "222-data-list-register-values x" \
- "222\\^done,register-values=\\\[\{number=\"0\",value=\"$hex\"\}.*\\\]" \
+ "222\\^done,register-values=\\\[\{number=\"$decimal\",value=\"$hex\"\}.*\\\]" \
"register values x"
mi_gdb_test "333-data-list-register-values f" \
- "333\\^done,register-values=\\\[\{number=\"0\",value=\"$float\"\}.*\\\]" \
+ "333\\^done,register-values=\\\[\{number=\"$decimal\",value=\"$float\"\}.*\\\]" \
"register values f"
mi_gdb_test "444-data-list-register-values d" \
- "444\\^done,register-values=\\\[\{number=\"0\",value=\"-?$decimal\"\}.*\\\]" \
+ "444\\^done,register-values=\\\[\{number=\"$decimal\",value=\"-?$decimal\"\}.*\\\]" \
"register values d"
mi_gdb_test "555-data-list-register-values o" \
- "555\\^done,register-values=\\\[\{number=\"0\",value=\"$octal\"\}.*\\\]" \
+ "555\\^done,register-values=\\\[\{number=\"$decimal\",value=\"$octal\"\}.*\\\]" \
"register values o"
mi_gdb_test "666-data-list-register-values t" \
- "666\\^done,register-values=\\\[\{number=\"0\",value=\"$binary\"\}.*\\\]" \
+ "666\\^done,register-values=\\\[\{number=\"$decimal\",value=\"$binary\"\}.*\\\]" \
"register values t"
}