This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA, doc RFA] set print frame-arguments-raw on|off


> From: Doug Evans <dje@google.com>
> Date: Sat, 29 Jun 2013 20:12:37 -0700
> 
>  > Sometimes it's nice to print stack frame arguments in raw form.
>  > [And not just as one-offs, but as the default.]
>  > 
>  > I thought of extending "set print frame-arguments" into something like
>  > none, raw-scalars, raw-all, scalars, all.
>  > But I like this better: raw-vs-pretty is orthogonal to scalars-vs-all.
>  > E.g., If we later extend "print frame-arguments" it'll be easier if raw-ness
>  > is a separate parameter.

Thanks.

> diff -u -p -r1.605 NEWS
> --- NEWS	26 Jun 2013 08:17:26 -0000	1.605
> +++ NEWS	30 Jun 2013 03:02:56 -0000
> @@ -34,6 +34,11 @@ maint set|show per-command symtab
>  
>  * New options
>  
> +set print frame-arguments-raw
> +show print frame-arguments-raw
> +  Set/show whether to print frame arguments in raw mode,
> +  not pretty-printed.
> +

This part is OK, although I'd suggest to say something more explicit,
like "... disregarding any defined pretty-printers."

> --- doc/gdb.texinfo	26 Jun 2013 08:17:26 -0000	1.1099
> +++ doc/gdb.texinfo	29 Jun 2013 22:11:03 -0000
> @@ -9030,6 +9030,17 @@ thus speeding up the display of each Ada
>  @item show print frame-arguments
>  Show how the value of arguments should be displayed when printing a frame.
>  
> +@item set print frame-arguments-raw on
> +Print frame arguments in raw, non pretty-printed, form.
> +
> +@item set print frame-arguments-raw off
> +Print frame arguments in pretty-printed form, if there is a pretty-printer
> +for the value (@pxref{Pretty Printing}).
> +Otherwise print the value in raw form.
> +
> +@item show print frame-arguments-raw
> +Show whether to print frame arguments in raw form.

This is fine, but please state the default value of the option.

OK with those changes.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]