This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/2] Code cleanup: remote.c *->{async,sync}*
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 1 Jul 2013 13:10:56 +0200
- Subject: Re: [patch 1/2] Code cleanup: remote.c *->{async,sync}*
- References: <20130630181059 dot GA29548 at host2 dot jankratochvil dot net> <51D150A9 dot 6070806 at codesourcery dot com>
On Mon, 01 Jul 2013 11:49:29 +0200, Yao Qi wrote:
> On 07/01/2013 02:10 AM, Jan Kratochvil wrote:
> >some code/variables are used only in async or sync mode. Rename them
> >appropriately. The state will be gdb_assert-ed in the next patch.
>
> Do we really need to rename these functions? It is necessary to add
> gdb_assert on various sync-only or async-only functions, but I don't
> think we can get any benefits from this function renaming.
A matter of opionion. While debugging the sync and async parts I had to write
a help text along which function gets used in which mode. Which I find the
{a,}sync_* prefies easier, moreover where already some functions/variables
contain *{a,}sync_* therein.
Jan