This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 01 Jul 2013 17:06:58 +0100
- Subject: Re: [PATCH 11/16] move some statics from remote_read_qxfer into struct remote_state
- References: <1372441229-305-1-git-send-email-tromey at redhat dot com> <1372441229-305-12-git-send-email-tromey at redhat dot com>
On 06/28/2013 06:40 PM, Tom Tromey wrote:
> This moves a few static variables out of remote_read_qxfer and into
> remote_state. It is unclear to me if this data can ever be required
> to be kept around across a potential target switch, but it is
> definitely safe to move it into the remote state object.
Hmm, are we still unclear about it? It seems to me that if we
dropped the data, we'd always be able to re-fetch it, though obviously
we'd lose on the optimization. It definitely seems to me that
putting it in the remote state object is the correct choice.
Maybe you're seeing something I'm not though.
--
Pedro Alves