This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Revised display-linkage-name
- From: Michael Eager <eager at eagerm dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 12 Jul 2013 14:17:23 -0700
- Subject: Re: [PATCH] Revised display-linkage-name
- References: <519D086A dot 50105 at eagerm dot com> <51BF47DB dot 6070709 at eagerm dot com> <51DD891D dot 7090009 at eagerm dot com> <51DF3F97 dot 90805 at redhat dot com>
On 07/11/13 16:28, Keith Seitz wrote:
On 07/10/2013 09:17 AM, Michael Eager wrote:
Can someone review and approve this patch?
Tom's been a little busy of late, so I thought I would try to help out here a little. You'll be one
step closer to approval!
Your patches no longer apply cleanly to HEAD, so I fixed them up to play with them. I'll be
commenting on this version.
...
Keith
Thanks. I'll look at your comments and submit an update.
I'll eliminate the whitespace changes; I find them annoying as well.
I'll allow passing a NULL for the linkname where the result is
not used. I'm not sure how the default got set to "on"; that was
not intentional, and yes, it causes a lot of noise regressions.
"Prepend" appears to be listed in some dictionaries as a synonym
for "prefix," but it may sound like jargon; I'll change it.
I'll look at the suggestions about the test suite. I've reasonable
experience with tcl/expect, but tcl always seems to turn into a tar pit.
If you have a different term for "linkage name" I'd be happy to
hear it. The only use of this that I was able to find is in the
DWARF Standard. Or I can add a definition to the docs to clarify.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077