This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH OB] Remove unused parameter in i386_linux_core_read_xcr0 and i386_in_stack_tramp_p


Hi,
I happen to see that parameters 'gdbarch' and 'target' are not used in
function i386_linux_core_read_xcr0 and parameter 'gdbarch' of function
i386_in_stack_tramp_p is not used either.

This patch is to remove these unused parameters.  It is obvious, and
I'll commit it in two days if no objections.

gdb:

2013-07-22  Yao Qi  <yao@codesourcery.com>

	* i386-tdep.c (i386_in_stack_tramp_p): Remove unused
	parameter 'gdbarch'.
	(i386_stack_tramp_frame_sniffer): Caller update.
	* i386-linux-tdep.c (i386_linux_core_read_xcr0): Remove parameter
	'gdbarch' and 'target'.
	(i386_linux_core_read_description): Caller update.
	* amd64-linux-tdep.c (amd64_linux_core_read_description): Likewise.
	* i386-linux-tdep.h (i386_linux_core_read_xcr0): Update declaration.
---
 gdb/amd64-linux-tdep.c |    2 +-
 gdb/i386-linux-tdep.c  |    5 ++---
 gdb/i386-linux-tdep.h  |    3 +--
 gdb/i386-tdep.c        |    5 ++---
 4 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index 88c291d..4f67762 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -1286,7 +1286,7 @@ amd64_linux_core_read_description (struct gdbarch *gdbarch,
 				  bfd *abfd)
 {
   /* Linux/x86-64.  */
-  uint64_t xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd);
+  uint64_t xcr0 = i386_linux_core_read_xcr0 (abfd);
   switch ((xcr0 & I386_XSTATE_AVX_MASK))
     {
     case I386_XSTATE_AVX_MASK:
diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c
index fc9de62..7b69aab 100644
--- a/gdb/i386-linux-tdep.c
+++ b/gdb/i386-linux-tdep.c
@@ -599,8 +599,7 @@ static int i386_linux_sc_reg_offset[] =
 /* Get XSAVE extended state xcr0 from core dump.  */
 
 uint64_t
-i386_linux_core_read_xcr0 (struct gdbarch *gdbarch,
-			   struct target_ops *target, bfd *abfd)
+i386_linux_core_read_xcr0 (bfd *abfd)
 {
   asection *xstate = bfd_get_section_by_name (abfd, ".reg-xstate");
   uint64_t xcr0;
@@ -642,7 +641,7 @@ i386_linux_core_read_description (struct gdbarch *gdbarch,
 				  bfd *abfd)
 {
   /* Linux/i386.  */
-  uint64_t xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd);
+  uint64_t xcr0 = i386_linux_core_read_xcr0 (abfd);
   switch ((xcr0 & I386_XSTATE_AVX_MASK))
     {
     case I386_XSTATE_AVX_MASK:
diff --git a/gdb/i386-linux-tdep.h b/gdb/i386-linux-tdep.h
index fc0d52d..8e4bbf7 100644
--- a/gdb/i386-linux-tdep.h
+++ b/gdb/i386-linux-tdep.h
@@ -35,8 +35,7 @@
 #define I386_LINUX_NUM_REGS (I386_LINUX_ORIG_EAX_REGNUM + 1)
 
 /* Get XSAVE extended state xcr0 from core dump.  */
-extern uint64_t i386_linux_core_read_xcr0
-  (struct gdbarch *gdbarch, struct target_ops *target, bfd *abfd);
+extern uint64_t i386_linux_core_read_xcr0 (bfd *abfd);
 
 /* Linux target description.  */
 extern struct target_desc *tdesc_i386_linux;
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 930d6fc..b159b49 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -2094,7 +2094,7 @@ struct i386_insn i386_tramp_chain_on_stack_insns[] =
 /* Return whether PC points inside a stack trampoline.   */
 
 static int
-i386_in_stack_tramp_p (struct gdbarch *gdbarch, CORE_ADDR pc)
+i386_in_stack_tramp_p (CORE_ADDR pc)
 {
   gdb_byte insn;
   const char *name;
@@ -2123,8 +2123,7 @@ i386_stack_tramp_frame_sniffer (const struct frame_unwind *self,
 				void **this_cache)
 {
   if (frame_relative_level (this_frame) == 0)
-    return i386_in_stack_tramp_p (get_frame_arch (this_frame),
-				  get_frame_pc (this_frame));
+    return i386_in_stack_tramp_p (get_frame_pc (this_frame));
   else
     return 0;
 }
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]