This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patchv2 2/2] Fix CTRL-C for remote.c (PR remote/15297)
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Jul 2013 17:25:23 +0200
- Subject: Re: [patchv2 2/2] Fix CTRL-C for remote.c (PR remote/15297)
- References: <20130630181110 dot GB29548 at host2 dot jankratochvil dot net> <8738r2wtsy dot fsf at fleche dot redhat dot com>
On Thu, 25 Jul 2013 17:19:57 +0200, Tom Tromey wrote:
> I read through this patch and it made sense, at least as far as I could
> understand it. It's a tricky area and without redoing the research you
> did I think it is reasonably hard to critique.
Thanks.
> Jan> The testcase does not work perfectly for target-async + all-stop,
> Jan> it is not being tested. I did not find it a commonly used mode and
> Jan> it may be fixed in a different/additional patch. It works in
> Jan> general but not in 100% cases.
>
> Can you characterize the failure modes? Or will I see it if I add a
> target-async+non-stop case to your new .exp?
^^^^^^^^^^^^^^^^^^^^^ - this one is there:
There are currently:
async-nonstop
sync-allstop
There is missing (and causing FAILs if added):
async-allstop
> I have a series here to always enable target-async, which I plan to
> submit soon. I'd like to understand this more so I can fix up my
> series.
You are right this "async-allstop" case has to be added. I was not sure what
is the expected behavior/output in such case, maybe GDB behaves correctly.
The patch got out of sync anyway, I will resubmit it.
Thanks,
Jan