This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Bilal <mbilal at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 30 Jul 2013 11:09:02 +0100
- Subject: Re: [PATCH PR gdb/15715] 'set history filename' to by immediately converted to absolute path.
- References: <97B73E257CC18646B0B5D3DD77DCBDD15DA063 at EU-MBX-02 dot mgc dot mentorg dot com> <97B73E257CC18646B0B5D3DD77DCBDD15DA08C at EU-MBX-02 dot mgc dot mentorg dot com> <51F27050 dot 6060409 at redhat dot com> <51F607C7 dot 7020108 at codesourcery dot com> <51F67A1A dot 8060602 at redhat dot com> <51F78DB7 dot 8010902 at codesourcery dot com>
On 07/30/2013 10:56 AM, Muhammad Bilal wrote:
> On 07/29/2013 07:20 PM, Pedro Alves wrote:
>>> >> static void
>>> >> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
>>> >> +{
>>> >> + /*We include the current directory so that if the user changes
>>> >> + directories the file written will be the same as the one
>>> >> + that was read. */
>> > Formatting still not right. Add a space after '/*', and then reindent.
>> > Also, there's trailing whitespace in the first two lines that should not
>> > The correct format is:
>> >
>> > /* We include the current directory so that if the user changes
>> > directories the file written will be the same as the one that
>> > was read. */
...
> 2013-07-30 Muhammad Bilal <mbilal@codesorcery.com>
>
> PR gdb/15715
> * top.c: include "filenames.h"
My initial suggestion was:
* top.c: Include "filenames.h".
That is, uppercase "include", and finish sentence with period.
Please fix this.
> static void
> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c)
> +{
> + /* We include the current directory so that if the user changes
> + directories the file written will be the same as the one
> + that was read. */
The trailing whitespace in first two comment lines is still there. And
this lost the double space after period; please add it back. Or just
copy the right formatting I pasted in the previous email...
--
Pedro Alves