This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] fix py-finish-breakpoint.exp with always-async
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 30 Jul 2013 12:10:07 -0600
- Subject: Re: [PATCH 7/8] fix py-finish-breakpoint.exp with always-async
- References: <1375116324-32092-1-git-send-email-tromey at redhat dot com> <1375116324-32092-8-git-send-email-tromey at redhat dot com> <20982 dot 64444 dot 939564 dot 557857 at ruffy dot mtv dot corp dot google dot com>
Doug> IOW, it'd be clearer if the patch did:
Doug> int was_executing = target_has_execution;
Doug> and then augment the patch with whatever else is necessary
Doug> to make it correct.
Doug> [Assuming I understand correctly what the patch is trying to do.]
I think what is happening is that we need to detect the transition from
"not executing" to "executing a sync command". But perhaps we don't
need to test sync_execution beforehand if we correctly detect execution.
Doug> Also, is target_has_execution what you want here?
Yeah, that is wrong.
Tom