This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: anton at samba dot org (Anton Blanchard)
- Cc: emachado at linux dot vnet dot ibm dot com (Edjunior Barbosa Machado), gdb-patches at sourceware dot org, brobecker at adacore dot com, luis_gustavo at mentor dot com
- Date: Thu, 1 Aug 2013 17:54:01 +0200 (CEST)
- Subject: Re: [PATCH 1/3] Fix ppc64 single step over atomic sequence testcase
Anton Blanchard wrote:
> > This seems to happen because -I option is not passed to the
> > assembler. I've tried adding this parameter using -Wa as:
> >
> > set compile_flags "debug quiet
> > additional_flags=-Wa,-I${srcdir}/gdb.asm"
> >
> > and it fixes the build failure. With this change, the testcase passes
> > OK, also including the other 2 patches you sent on this thread.
>
> Thanks for the fix! Incorporated below.
I think it might be best to just get rid of those .include statements;
depending on an .inc file from another directory seems surprising.
It seems you only need it for the gdbasm_declare macro; since this
file is ppc64 specific anyway, why don't you just hard-code the
.opd generation in this source file?
Also, the assembler source file probably ought to keep the
copyright header. A comment why this test needs to use
assembler source also would be good.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com