This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] remove duplicates in search_symbols
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 02 Aug 2013 11:00:01 -0600
- Subject: Re: [RFA] remove duplicates in search_symbols
- References: <yjt2ppvmu3ae dot fsf at ruffy dot mtv dot corp dot google dot com> <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ at mail dot gmail dot com> <8738r68uze dot fsf at fleche dot redhat dot com> <20986 dot 62497 dot 975502 dot 698564 at ruffy dot mtv dot corp dot google dot com> <51FB2A02 dot 6080703 at redhat dot com> <87pptwdx41 dot fsf at fleche dot redhat dot com> <CADPb22Q0_MWssituUuwV_HqptkUQLAU06SDfMGGPqa6XFG5PrA at mail dot gmail dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> /* Symbol searching */
Doug> /* Note: struct symbol_search, search_symbols, et.al. are declared
Doug> here,
Doug> instead of making them local to symtab.c, for gdbtk's sake. */
Funny.
Doug> [I could make it more prevalent though. Say a comment at the
Doug> definition site of each function or some such?]
I hope the above is good enough.
I didn't notice it once, but OTOH that implies that I'd probably miss
other comments as well.
Tom