This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch v4 01/24] gdbarch: add instruction predicate methods
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 18 Aug 2013 21:04:05 +0200
- Subject: Re: [patch v4 01/24] gdbarch: add instruction predicate methods
- References: <1372842874-28951-1-git-send-email-markus dot t dot metzger at intel dot com> <1372842874-28951-2-git-send-email-markus dot t dot metzger at intel dot com>
On Wed, 03 Jul 2013 11:14:11 +0200, Markus Metzger wrote:
[...]
> diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
> index c92a857..5b73301 100755
> --- a/gdb/gdbarch.sh
> +++ b/gdb/gdbarch.sh
> @@ -976,6 +976,15 @@ m:void:iterate_over_objfiles_in_search_order:iterate_over_objfiles_in_search_ord
>
> # Ravenscar arch-dependent ops.
> v:struct ravenscar_arch_ops *:ravenscar_ops:::NULL:NULL::0:host_address_to_string (gdbarch->ravenscar_ops)
> +
> +# Return non-zero if the instruction at ADDR is a call; zero otherwise.
> +M:int:insn_is_call:CORE_ADDR addr:addr::default_insn_is_call
> +
> +# Return non-zero if the instruction at ADDR is a return; zero otherwise.
> +M:int:insn_is_ret:CORE_ADDR addr:addr::default_insn_is_ret
> +
> +# Return non-zero if the instruction at ADDR is a jump; zero otherwise.
> +M:int:insn_is_jump:CORE_ADDR addr:addr::default_insn_is_jump
As you no longer use the gdbarch_METHODNAME_p checks if the method is
implemented on that gdbarch you can change the initial 'M' to 'm' so that
these unused *_p methods are no longer generated.
> EOF
> }
>
[...]