This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver
- From: Tom Tromey <tromey at redhat dot com>
- To: lgustavo at codesourcery dot com
- Cc: "'gdb-patches\ at sourceware dot org'" <gdb-patches at sourceware dot org>, Pedro Alves <palves at redhat dot com>
- Date: Tue, 20 Aug 2013 10:14:12 -0600
- Subject: Re: [PATCH, v2] Share ptrace options discovery/linux native code between GDB and gdbserver
- References: <5212A9E1 dot 6030707 at codesourcery dot com> <87d2p8id9f dot fsf at fleche dot redhat dot com> <52138F32 dot 3020601 at codesourcery dot com>
>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
Luis> Right. Should i move it now as part of this cleanup or should i move
Luis> it in a follow up?
Probably preferable as a follow-up.
Or a prequel.
>> Also, doesn't this check need to be done in gdbserver as well?
Luis> For gdbserver we explicitly define the correct types for each argument.
Ok, I see.
Luis> Since this is a runtime check, we may run into issues if we attempt to
Luis> run a binary on a build machine if the target machine is from a
Luis> different architecture. Does it make sense?
I looks like an AC_TRY_COMPILE check to me. That means it is safe.
However, if it isn't needed for gdbserver, then the point is moot.
Tom