This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] buildsym.c cleanup
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Tue, 20 Aug 2013 12:00:55 -0700
- Subject: Re: [RFA] buildsym.c cleanup
- References: <yjt2fvxpwnu0 dot fsf at ruffy dot mtv dot corp dot google dot com> <87ehd95tl6 dot fsf at fleche dot redhat dot com> <20130520090312 dot GM4017 at adacore dot com> <CADPb22SMF0-CL7Ryp3LjDseQRui_maCHL65uBZcM3O7eJwsd_A at mail dot gmail dot com> <87txjm7fid dot fsf at fleche dot redhat dot com>
On Mon, Jul 22, 2013 at 8:58 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> On Mon, May 20, 2013 at 2:03 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>>>> I have no idea about the COFF change. It isn't clear to me whether
>>>> coffread and stabsread expect to share the same globals or not.
>>>
>>> I do not have a real idea either, but looking at the code, I do not
>>> think so. The indices used to index the types seem completely
>>> unrelated...
>
> Doug> Hi. So what's the verdict here?
> Doug> Should we wait until we can find someone to test this on coff, or
> Doug> check the patch in now.
>
> Joel said he thinks the globals aren't shared.
> If you agree then I think it is fine to go ahead and put it in.
Committed.
For reference sake, I did an m32r-coff port of binutils,gcc,newlib,gdb
to do some additional testing.
[found some m32r issues, which is good, and I now have a simple port
from which to do further coff testing should it be necessary - though
I'm happy to see coff go anytime. :-)]