This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Waqas <mwaqas at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 27 Aug 2013 20:06:40 +0100
- Subject: Re: [PATCH with testcase] Bug 11568 - delete thread-specific breakpoint on the thread exit
- Authentication-results: sourceware.org; auth=none
- References: <521646F5 dot 1010509 at redhat dot com> <1377602943-9177-1-git-send-email-mwaqas at codesourcery dot com> <521CF7D0 dot 5040801 at redhat dot com>
On 08/27/2013 08:02 PM, Pedro Alves wrote:
> On 08/27/2013 12:29 PM, Muhammad Waqas wrote:
>> 2013-08-05 Muhammad Waqas <mwaqas@codesourcery.com>
>>
>> PR gdb/11568
>> * breakpoint.c (remove_threaded_breakpoints): New function.
>> * breakpoint.c (_initialize_breakpoint): function
>> remove_threaded_breakpoints registers with thread_exit.
>
> Indentation isn't right.
> See <https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_Formatted_GNU_ChangeLog>.
>
> "Function" should be uppercase.
>
I meant to suggest something else, but forgot to go back and edit it in.
> * breakpoint.c (_initialize_breakpoint): Function
> remove_threaded_breakpoints registers with thread_exit.
I have a little trouble parsing that. I suggest:
* breakpoint.c (_initialize_breakpoint): Attach
remove_threaded_breakpoints as thread_exit observer.
--
Pedro Alves