This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: FYI: fix test name in gdb-index.exp
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 28 Aug 2013 09:58:23 -0600
- Subject: Re: FYI: fix test name in gdb-index.exp
- Authentication-results: sourceware.org; auth=none
- References: <87vc2px5g3 dot fsf at fleche dot redhat dot com> <CADPb22TJB-ibCvZXrQNOgTW9kVwP2oj7HCK6OWCEct+bUbRxRg at mail dot gmail dot com>
Doug> TIL: It's not just that test names have to be unique, but they can no
Doug> longer include build directory names because the latter can be machine
Doug> generated, and when diff'ing before/after runs it can lead to spurious
Doug> output needing investigating.
Yeah, I think it's actually always been that way.
I've fixed a number of these over the years.
Basically anything that makes the test names differ across runs is bad.
This is hard to fix in the general case but something like the directory
name is an easy one.
Doug> Good to know, thanks. And good thing to add to the testcase cookbook.
Will do.
Tom