Re: RFA [PATCH] Implement 'catch syscall' for gdbserver

[Philippe Waroquiers <philippe dot waroquiers at skynet dot be>]

On Fri, 2013-08-30 at 18:44 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Date: Fri, 30 Aug 2013 17:26:28 +0200
> > 
> > This is the 2nd version of the patch implementing 'catch syscalls' for
> > gdbserver.
> > First version was sent in an RFC (no feedback yet, so here is a completed
> > and tested RFA ready version).
> > Tested (no regression) on linux amd64, native and gdbserver.
> > Manually tested with a patched Valgrind gdbserver.
> 
> Thanks.  The documentation parts are OK, but please be sure to leave 2
> spaces between sentences (some of them have only one in this
> changeset).
Oops, sorry, even if my brain knows it, my fingers don't.

Fixed the occurences detected with:
grep '\. [^ ]' patch.txt
+	     max 8+1 characters for a sysno. If the resulting
+	      /* catch_packet too big. Fallback to less efficient
+in hex) should be reported to @value{GDBN}. If no syscall @var{sysno}
+will filter it if this signal is not catched. It is however more efficient
+  /* Fill SYSNO with the syscall nr trapped. Fill SYSRET with the
+/* 1 if some (or all) syscalls are catched. */

Thanks for the quick review

Philippe