This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Pedro Alves'" <palves at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 2 Sep 2013 14:48:19 +0200
- Subject: RE: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in windows_xfer_memory function
- Authentication-results: sourceware.org; auth=none
- References: <5223bb46 dot c6c0420a dot 5a41 dot 008dSMTPIN_ADDED_BROKEN at mx dot google dot com> <522485BB dot 8000904 at redhat dot com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : lundi 2 septembre 2013 14:34
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] windows-nat.c: Handle ERROR_PARTIAL_COPY in
> windows_xfer_memory function
>
> On 09/01/2013 11:10 PM, Pierre Muller wrote:
> >
> > PS: the use of plongest function is because I got an warning about %d
> > used for 'long long integer' type.
>
> Then that's a regression from my deprecated_xfer_memory change.
> Please keep logically independent changes as separate patches.
I just noticed the problem while
trying to update the patch...
You are off course right that this should be separate...
> > 2013-09-01 Pierre Muller <muller@sourceware.org>
> >
> > * windows-nat.c (windows_xfer_memory): Fix compilation failure
> > by use of plongest function.
>
> This part is OK. Please split it out, and commit it.
Done and committed,
thanks,
Pierre
PS: Do you want me to resubmit and new version of the ERROR_PARTIAL_COPY
RFA?