This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFC 2/3] Perf test framework


> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf
> Of Yao Qi
> Sent: Tuesday, September 03, 2013 03:44 AM
> To: Agovic, Sanimir
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFC 2/3] Perf test framework
> 
> On 08/28/2013 05:57 PM, Agovic, Sanimir wrote:
> > I would put a copyright header and a module __doc__ into __init__.py
> >
> 
> What do you mean by "put a module __doc__ into __init__.py"?
>
Add a comment in __init__.py and briefly describe the module, it will show up
during help(perftest)/pydoc.

> Abstract Base Class should be useful here.  It was introduced in python
> 2.6, but GDB should support some older pythons.  I don't know what are
> the versions of python GDB support, 2.4 ~ 3.0?, but some code in
> gdb/python/ is written with 2.4 considered.
> 
I see. As an alternative you may consider throwing NotImplementedError instead.

> Other comments are addressed, and I'll post the updated patch in next
> round.
> 
Thanks.

 -Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]