This part looks OK, though it did raise some eyebrows to have
GNU/Linux-specific code in cris-tdep.c, rather than in a cris-linux-tdep.c
file. It seems there's no real support for cris bare-metal debugging?
...
I don't really see the need for it. It doesn't seem like it would be a
huge effort (essentially the call to
set_gdbarch_fetch_tls_load_module_address and also
set_solib_svr4_fetch_link_map_offsets would be put in cris-linux-tdep.c),
on the other hand I can't really test that it works as expected,
...
It's mostly about code/design/maintenance sanity. I won't really mind if the
split isn't done, but note how the fact that there's a Linux port here
is being missed often in regular maintenance (because people will look
for *linux-tdep.*) files. cris-tdep.c doesn't call linux_init_abi anywhere
AFAICT, for example, so the cris port lost the adjustment between v1
and v2 of the gdbarch_gdb_signal_{to,from}_target
patches, just a few weeks back:
http://sourceware.org/ml/gdb-patches/2013-07/msg00002.html
http://sourceware.org/ml/gdb-patches/2013-07/msg00651.html
Probably other across-the-board changes have been missed.