This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/3] Use gdb_realpath in gdb_bfd_open


Jan Kratochvil writes:
 > Hi,
 > 
 > it seems logical to always call gdb_realpath() in gdb_bfd_open(), IIRC also
 > suggested by Doug.  Currently all the callers already pass in
 > gdb_realpath()-canonicalized filenames but [patch 3/3] will change that.
 > 
 > This patch has no user visible effect (except for lower GDB performance).
 > 
 > 
 > Jan
 > 
 > 
 > gdb/
 > 2013-08-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
 > 
 > 	Use gdb_realpath in gdb_bfd_open.
 > 	* gdb_bfd.c (struct gdb_bfd_data): Add field canonical_filename.
 > 	(struct gdb_bfd_cache_search): Rename field filename to
 > 	canonical_filename.
 > 	(hash_bfd): New variable gdata.  Use gdata->canonical_filename.
 > 	(eq_bfd): Use gdata->canonical_filename and
 > 	gdb_bfd_cache_search::canonical_filename.
 > 	(gdb_bfd_open): New variables canonical_name, canonical_name_copy and
 > 	gdata.  Initialize canonical_name with gdb_realpath and use it.
 > 	Call xfree for it when needed.  Store it also to
 > 	gdata->canonical_filename.
 > 	(gdb_bfd_ref): Set gdata->canonical_filename.
 > 	(gdb_bfd_unref): Use gdata->canonical_filename.  Rename the use of
 > 	struct gdb_bfd_cache_search.

Thanks.
ok by me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]