This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] python events test minor cleanup


Hi.
I committed the following cleanup.
Regression tested on amd64-linux.

2013-09-04  Doug Evans  <dje@google.com>

	* gdb.python/py-events.py (exit_handler): Verify we get the expected
	event.
	(continue_handler, new_objfile_handler): Ditto.
	(test_events): Rename command to "test-events".
	(test_newobj_events): Rename command to "test-objfile-events".
	* gdb.python/py-events.exp: Update.
	* gdb.python/py-evsignal.exp: Update.
	* gdb.python/py-evthreads.exp: Update.

Index: py-events.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-events.exp,v
retrieving revision 1.14
diff -u -p -r1.14 py-events.exp
--- py-events.exp	1 Jan 2013 06:41:26 -0000	1.14
+++ py-events.exp	4 Sep 2013 23:43:02 -0000
@@ -45,7 +45,7 @@ if { [skip_python_tests] } { continue }
 
 gdb_test_no_output "python exec (open ('${pyfile}').read ())" ""
 
-gdb_test "Test_Newobj_Events" "New ObjectFile Event tester registered." "Register new objfile event handler"
+gdb_test "test-objfile-events" "Object file events registered."
 
 gdb_breakpoint "main" {temporary}
 
@@ -53,7 +53,7 @@ gdb_test "run" ".*event type: new_objfil
 
 gdb_test_no_output "set detach-on-fork off" ""
 
-gdb_test "Test_Events" "Event testers registered."
+gdb_test "test-events" "Event testers registered."
 
 gdb_breakpoint "first"
 gdb_breakpoint "first"
Index: py-events.py
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-events.py,v
retrieving revision 1.8
diff -u -p -r1.8 py-events.py
--- py-events.py	1 Jan 2013 06:41:26 -0000	1.8
+++ py-events.py	4 Sep 2013 23:43:02 -0000
@@ -40,31 +40,29 @@ def breakpoint_stop_handler (event):
             print ("all threads stopped")
 
 def exit_handler (event):
-    if (isinstance (event, gdb.ExitedEvent)):
-        print ("event type: exit")
+    assert (isinstance (event, gdb.ExitedEvent))
+    print ("event type: exit")
     print ("exit code: %d" % (event.exit_code))
     print ("exit inf: %d" % (event.inferior.num))
     print ("dir ok: %s" % str('exit_code' in dir(event)))
 
 def continue_handler (event):
-    if (isinstance (event, gdb.ContinueEvent)):
-        print ("event type: continue")
+    assert (isinstance (event, gdb.ContinueEvent))
+    print ("event type: continue")
     if ( event.inferior_thread is not None) :
         print ("thread num: %s" % (event.inferior_thread.num))
 
 def new_objfile_handler (event):
-    if (isinstance (event, gdb.NewObjFileEvent)):
-        print ("event type: new_objfile")
-    if (event.new_objfile is not None):
-    	print ("new objfile name: %s" % (event.new_objfile.filename))
-    else:
-        print ("new objfile is None")
+    assert (isinstance (event, gdb.NewObjFileEvent))
+    print ("event type: new_objfile")
+    print ("new objfile name: %s" % (event.new_objfile.filename))
+    print ("inferior number: %d" % (event.inferior.num))
 
 class test_events (gdb.Command):
     """Test events."""
 
     def __init__ (self):
-        gdb.Command.__init__ (self, "test_events", gdb.COMMAND_STACK)
+        gdb.Command.__init__ (self, "test-events", gdb.COMMAND_STACK)
 
     def invoke (self, arg, from_tty):
         gdb.events.stop.connect (signal_stop_handler)
@@ -79,10 +77,10 @@ class test_newobj_events (gdb.Command):
     """NewObj events."""
 
     def __init__ (self):
-        gdb.Command.__init__ (self, "test_newobj_events", gdb.COMMAND_STACK)
+        gdb.Command.__init__ (self, "test-objfile-events", gdb.COMMAND_STACK)
 
     def invoke (self, arg, from_tty):
         gdb.events.new_objfile.connect (new_objfile_handler)
-        print ("New ObjectFile Event tester registered.")
+        print ("Object file events registered.")
 
 test_newobj_events ()
Index: py-evsignal.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-evsignal.exp,v
retrieving revision 1.6
diff -u -p -r1.6 py-evsignal.exp
--- py-evsignal.exp	1 Jan 2013 06:41:26 -0000	1.6
+++ py-evsignal.exp	4 Sep 2013 23:43:02 -0000
@@ -33,7 +33,7 @@ if { [skip_python_tests] } { continue }
 
 gdb_test_no_output "python exec (open ('${pyfile}').read ())" ""
 
-gdb_test "Test_Events" "Event testers registered."
+gdb_test "test-events" "Event testers registered."
 gdb_test_no_output "set non-stop on"
 gdb_test_no_output "set target-async on"
 
Index: py-evthreads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-evthreads.exp,v
retrieving revision 1.11
diff -u -p -r1.11 py-evthreads.exp
--- py-evthreads.exp	1 Jan 2013 06:41:26 -0000	1.11
+++ py-evthreads.exp	4 Sep 2013 23:43:02 -0000
@@ -38,7 +38,7 @@ if { [skip_python_tests] } { continue }
 
 gdb_test_no_output "python exec (open ('${pyfile}').read ())" ""
 
-gdb_test "Test_Events" "Event testers registered."
+gdb_test "test-events" "Event testers registered."
 gdb_test_no_output "set non-stop on"
 gdb_test_no_output "set target-async on"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]