This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
- From: Raunaq 12 <raunaq12 at in dot ibm dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, GDB Patches <gdb-patches at sourceware dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>
- Date: Tue, 10 Sep 2013 15:44:19 +0530
- Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnynVeLt6F-QREsP_CtQvwvtZgwqHxtcS6pn58LMf=AX=GA at mail dot gmail dot com> <OF91B6D42F dot B0CFCB9C-ON65257BC5 dot 004284AA-65257BC5 dot 0042F553 at in dot ibm dot com> <CAGWvnynzsNL--qPhHOhqZ912A4M9ZpXtT2JbjW4EHRodEXAF9Q at mail dot gmail dot com> <20130822233234 dot GA13292 at adacore dot com> <20130823004837 dot GC5221 at adacore dot com> <CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w at mail dot gmail dot com> <20130823133415 dot GD5221 at adacore dot com> <CAGWvnyna5R2AR0imAC4W+aCJXPFjwPm+45yP9VOgkO68T7sF7w at mail dot gmail dot com>
David Edelsohn <dje.gcc@gmail.com> wrote on 08/23/2013 08:44:23 PM:
> From: David Edelsohn <dje.gcc@gmail.com>
> To: Joel Brobecker <brobecker@adacore.com>
> Cc: Raunaq 12/India/IBM@IBMIN, GDB Patches <gdb-patches@sourceware.org>,
Mark Kettenis
> <mark.kettenis@xs4all.nl>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
> Date: 08/23/2013 08:43 PM
> Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH
4/5] powerpc64-aix
> ptrace64 when defined.")
>
> On Fri, Aug 23, 2013 at 9:34 AM, Joel Brobecker <brobecker@adacore.com>
wrote:
>
> >> Is there a testcase that can be added to the GDB testsuite to catch
> >> this type of regression?
> >
> > All testcases involving thread support should reveal this type of
> > failure. I cannot remember exactly how this patch was tested, but
> > ISTR that it couldn't be tested through the official testsuite,
> > for some reasons that were deemed reasonable...
>
> Uli and I both asked Raunaq if the patch had been tested with the
> testsuite. However, the testsuite may not have been run with the full
> matrix: GDB32 -> Testsuite32, GDB32 ->Testsuite64, GDB64 ->
> Testsuite32, GDB64 -> Testsuite64.
Was out of office for a while so couldn't reply earlier. Sorry for that.
David, my intention was to run test cases for all the combinations that you
have mentioned above. Since we use XLC (AIX native compiler) to compile the
test cases, the entire test bucket does not run very smoothly. In fact it
is a
very cumbersome process. So the test failures would have been over looked
by me.
In future, I will stick to using GCC to compile the test cases to ensure a
smoother
execution of the test bucket.
Joel, thanks for fixing the regression:) Applied the patch on my AIX
machine and it does
not cause any issues in 32/64 BIT.
Regards,
Raunaq M. Bathija