This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Run catch-load.exp on Windows
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 12 Sep 2013 05:44:39 +0300
- Subject: Re: [PATCH] Run catch-load.exp on Windows
- Authentication-results: sourceware.org; auth=none
- References: <1378947563-26245-1-git-send-email-yao at codesourcery dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 12 Sep 2013 08:59:23 +0800
>
> I find a compilation error when catch-load.c is compiled.
>
> catch-load.c:18:19: fatal error: dlfcn.h: No such file or directory
>
> This patch is to fix this compilation error. With this patch applied,
> test case can be compiled successfully. However, there is one fail
> caused by matching "/" in file name, which doesn't exist on Windows.
> This patch fixes it by matching either "/" or "\" in file name.
>
> gdb/testsuite:
>
> 2013-09-12 Yao Qi <yao@codesourcery.com>
>
> * gdb.base/catch-load.c: Remove the include of "dlfcn.h".
> [__WIN32__]: Include "windows.h" and define macro dlopen
> and dlclose.
> [!__WIN32__]: Include "dlfcn.h".
Isn't it better to create a new file gdb_dlfcn.h, and move all the
portability stuff there?