This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: 'Ulrich Weigand' <uweigand at de dot ibm dot com>, gdb-patches at sourceware dot org
- Date: Mon, 16 Sep 2013 05:23:45 -0700
- Subject: Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset]
- Authentication-results: sourceware.org; auth=none
- References: <002701ceb25b$2e880fc0$8b982f40$ at muller@ics-cnrs.unistra.fr> <201309160951 dot r8G9pr5B021687 at d06av02 dot portsmouth dot uk dot ibm dot com> <003e01ceb2d0$c5051770$4f0f4650$ at muller@ics-cnrs.unistra.fr>
> PS:I think that system includes should be banned
> in all files that are used for cross-debugging.
This is already the main idea, except that we cannot banish
all system includes. For instance, includes that are part of
the C standard are OK (ctype.h, stdint.h, stdarg.h, etc) are
fine. Others, such as dlfcn.h or sys/cygwin.h, on the other
hand, are not.
> Especially cases like <string.h> should be avoided as we do have
> common/gdb_string.h...
Agreed on this one.
--
Joel