This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/4] Match \r\r\n in testsuite
- From: Yao Qi <yao at codesourcery dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 18 Sep 2013 16:20:18 +0800
- Subject: Re: [PATCH 0/4] Match \r\r\n in testsuite
- Authentication-results: sourceware.org; auth=none
- References: <87a9ldyu8k dot fsf at fleche dot redhat dot com> <1379423179-8515-1-git-send-email-yao at codesourcery dot com> <20130917133530 dot GH3132 at adacore dot com> <52386003 dot 2050501 at codesourcery dot com> <20130917140603 dot GK3132 at adacore dot com>
On 09/17/2013 10:06 PM, Joel Brobecker wrote:
Can we look at fixing gdb_test to use that $eol instead? Is that
even necessary? I see the implementation is:
return [gdb_test_multiple $command $message {
-re "\[\r\n\]*($pattern)\[\r\n\]+$gdb_prompt $" {
if ![string match "" $message] then {
pass "$message"
}
}
It seems to me that it should match ${eol} already, no?
Yes, this pattern above should match ${eol}. However, how about the
code using gdb_test_mulitiple or gdb_expect to match? We have to fix
them too. We don't want to replace all instances of \r\n with ${eol},
which is painful.
--
Yao (éå)