This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Changing size of c_value in xcoffread.c to accomodate XCOFF 64BIT
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: raunaq12 at in dot ibm dot com (Raunaq 12)
- Cc: brobecker at adacore dot com, gdb-patches at sourceware dot org, palves at redhat dot com (Pedro Alves), tromey at redhat dot com
- Date: Wed, 18 Sep 2013 19:49:08 +0200 (CEST)
- Subject: Re: [PATCH] Changing size of c_value in xcoffread.c to accomodate XCOFF 64BIT
- Authentication-results: sourceware.org; auth=none
Raunaq 12 wrote:
> > > Yes, I did not account for such a scenario. Changing the size of
> > > cs->c_value to 'long long' will suffice ?
> >
> > I think it really needs to be CORE_ADDR. Note that "long long" shouldn't
> > be used in common code since on some systems / compilers this data type
> > isn't even available ...
>
> Oh alright, assigning it to CORE_ADDR itself, thanks.
> This okay to check in ?
>
> ChangeLog-
> * xcoffread.c : Make coff_symbol->c_value
> large enough to hold 64-bit address.
> (read_xcoff_symtab): Make fcn_start_addr
> large enough to hold 64-bit address.
This is OK. I've checked it in now.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com