This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [COMMIT PATCH] [Hurd/gnu-nat] Fix old "signal-thread" command regression.

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: <gdb-patches at sourceware dot org>, <bug-hurd at gnu dot org>
Date: Thu, 19 Sep 2013 10:46:27 +0200
Subject: Re: [COMMIT PATCH] [Hurd/gnu-nat] Fix old "signal-thread" command regression.
Authentication-results: sourceware.org; auth=none
References: <20130918120139 dot 28227 dot 96077 dot stgit at brno dot lan>

Hi Pedro!

On Wed, 18 Sep 2013 13:01:39 +0100, Pedro Alves <palves@redhat.com> wrote:
> By inspection, I noticed that when I made the gnu-nat use
> ptid(pid,0,tid) to represent a thread, instead of using ptid(tid,0,0),
> in <https://sourceware.org/ml/gdb-patches/2008-08/msg00175.html>, I
> introduced a bug.
> 
> The change was: [...]

> So before, [...]
> 
> The right fix is to compare the whole ptid to minus_one_ptid, of
> course.
> 
> Completely untested, but I think it's obvious enough, so I went ahead
> and put it in.

Thanks!  Now confirmed the issue as well as the fix.


As I found some months ago, Hurd GDB's signal-thread detection is broken
anyway, but despite that, GDB does work -- will have to look into that.


GrÃÃe,
 Thomas

Attachment: pgp2BOojTNpLW.pgp
Description: PGP signature

References:
- [COMMIT PATCH] [Hurd/gnu-nat] Fix old "signal-thread" command regression.
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]