This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Use AMD64_RX_REGNUM for X from 8 to 15 ind amd64*tdep.c sources
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'gdb-patches'" <gdb-patches at sourceware dot org>
- Date: Thu, 19 Sep 2013 23:36:35 +0200
- Subject: [RFA] Use AMD64_RX_REGNUM for X from 8 to 15 ind amd64*tdep.c sources
- Authentication-results: sourceware.org; auth=none
As suggested by Joel
in a previous thread called "[RFC-v2] amd64-windows: Fix funcall with
by-pointer arguments"
I submit here independently a fairly obvious
cleanup that changes immediate values 8 to 15 by
corresponding AMD64_RX_REGNUM
enumeration values.
2013-09-19 Pierre Muller <muller@sourceware.org>
Replace constant values 8 to 15 by AMD64_R8_REGNUM to
AMD64_R15_REGNUM when a register index is expected.
* amd64-windows-tdep.c (amd64_windows_dummy_call_integer_regs):
Ditto.
* amd64-tdep.c (amd64_dummy_call_integer_regs): Ditto.
(amd64_dwarf_regmap): Ditto.
Index: src/gdb/amd64-windows-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-windows-tdep.c,v
retrieving revision 1.17
diff -u -p -r1.17 amd64-windows-tdep.c
--- src/gdb/amd64-windows-tdep.c 2 Sep 2013 09:28:02 -0000 1.17
+++ src/gdb/amd64-windows-tdep.c 17 Sep 2013 13:09:29 -0000
@@ -37,8 +37,8 @@ static int amd64_windows_dummy_call_inte
{
AMD64_RCX_REGNUM, /* %rcx */
AMD64_RDX_REGNUM, /* %rdx */
- 8, /* %r8 */
- 9 /* %r9 */
+ AMD64_R8_REGNUM, /* %r8 */
+ AMD64_R9_REGNUM /* %r9 */
};
/* Implement the "classify" method in the gdbarch_tdep structure
Index: src/gdb/amd64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-tdep.c,v
retrieving revision 1.117
diff -u -p -r1.117 amd64-tdep.c
--- src/gdb/amd64-tdep.c 1 Jan 2013 06:32:37 -0000 1.117
+++ src/gdb/amd64-tdep.c 17 Sep 2013 13:09:30 -0000
@@ -99,8 +99,8 @@ static int amd64_dummy_call_integer_regs
AMD64_RSI_REGNUM, /* %rsi */
AMD64_RDX_REGNUM, /* %rdx */
AMD64_RCX_REGNUM, /* %rcx */
- 8, /* %r8 */
- 9 /* %r9 */
+ AMD64_R8_REGNUM, /* %r8 */
+ AMD64_R9_REGNUM /* %r9 */
};
/* DWARF Register Number Mapping as defined in the System V psABI,
@@ -120,7 +120,14 @@ static int amd64_dwarf_regmap[] =
AMD64_RSP_REGNUM,
/* Extended Integer Registers 8 - 15. */
- 8, 9, 10, 11, 12, 13, 14, 15,
+ AMD64_R8_REGNUM, /* %r8 */
+ AMD64_R9_REGNUM, /* %r9 */
+ AMD64_R10_REGNUM, /* %r10 */
+ AMD64_R11_REGNUM, /* %r11 */
+ AMD64_R12_REGNUM, /* %r12 */
+ AMD64_R13_REGNUM, /* %r13 */
+ AMD64_R14_REGNUM, /* %r14 */
+ AMD64_R15_REGNUM, /* %r15 */
/* Return Address RA. Mapped to RIP. */
AMD64_RIP_REGNUM,