This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Sim hangs on new target at dup_arg_p() in infinite loop.
- From: Tom Tromey <tromey at redhat dot com>
- To: Alexey Makhalov <makhaloff at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 20 Sep 2013 11:33:43 -0600
- Subject: Re: Sim hangs on new target at dup_arg_p() in infinite loop.
- Authentication-results: sourceware.org; auth=none
- References: <CALd+sgcTRoRt94vXkWZ62xzb7q_mhfkuUXUFs3EwGdAs-1TQEg at mail dot gmail dot com> <87bo3rz790 dot fsf at fleche dot redhat dot com> <CALd+sgeSJz46ja1xbbFYO12kiF=LjVCaF2Xy_TzeMUkPkwZVmw at mail dot gmail dot com> <CALd+sge-JGnmCc3Sj1iExukM=J9n=QM2ZgUmBPZa9FKvJwyBfg at mail dot gmail dot com>
>>>>> "Alexey" == Alexey Makhalov <makhaloff@gmail.com> writes:
Alexey> + arg_table = htab_create (ARG_HASH_SIZE, htab_hash_string,
Alexey> + (int (*)(const void *, const void *)) streq, free);
I think casts like this are better avoided.
Since streq is only used here, it is no trouble to just give it the
proper type.
Alexey> + *slot = strdup(arg);
The GNU coding style requires a space before the paren here.
Tom