This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Sim hangs on new target at dup_arg_p() in infinite loop.


>>>>> "Alexey" == Alexey Makhalov <makhaloff@gmail.com> writes:

Alexey> +        arg_table = htab_create (ARG_HASH_SIZE, htab_hash_string,
Alexey> +               (int (*)(const void *, const void *)) streq, free);

I think casts like this are better avoided.
Since streq is only used here, it is no trouble to just give it the
proper type.

Alexey> +  *slot = strdup(arg);

The GNU coding style requires a space before the paren here.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]