This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 2/3] Perf test framework
- From: Doug Evans <dje at google dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Sun, 22 Sep 2013 16:14:10 -0700
- Subject: Re: [RFC 2/3] Perf test framework
- Authentication-results: sourceware.org; auth=none
- References: <520B7F70 dot 6070207 at codesourcery dot com> <1377663394-4975-1-git-send-email-yao at codesourcery dot com> <1377663394-4975-3-git-send-email-yao at codesourcery dot com> <21051 dot 19430 dot 251374 dot 942418 at ruffy dot mtv dot corp dot google dot com> <523C015E dot 30902 at codesourcery dot com> <CADPb22TFyjcjYnmG2BnADh7qx6sSvcQqEMrJh95RJmxeT2GovA at mail dot gmail dot com> <523E5BB8 dot 1080406 at codesourcery dot com>
On Sat, Sep 21, 2013 at 7:53 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 09/21/2013 12:51 AM, Doug Evans wrote:
>>>
>>> I was wondering that we can support json format, so I create class
>>> >PerfTestConfig and perftest.ini is used to determine which format to
>>> >be used. I agree that we can remove PerfTestConfig since we
>>> >only support only one format (plain text) nowadays.
>>
>> Hi. I wasn't suggesting removing support for more reporting formats.
>> We'll be adding our own.:-)
>>
>> I'm just wondering, if all that pertest.ini will contain is the report
>> format, do we need it?
>
>
> perftest.ini only contains report format so far, but the perf test framework
> needs more and more customizations, so perftest.ini will contain more
> stuffs.
>
>
>> Or, can we specify the format (and whatever else is desired/needed)
>> via some other means?
>
>
> by env var? I thought of this, but this doesn't scale to me, if we have
> more to set.
No, I wasn't suggesting using env vars ... :-)
[Yikes!]
I was thinking of just python.
>> How will the user specify the desired report format?
>>
>
> in testsuite/perftest.ini
> [Reporter]
> type = TextReporter
>
> In short, we don't have anything to customize in perf test, so I am OK to
> remove PerfTestConfig. Once we want to do customization, I still prefer to
> do it through config file, like perftest.ini.
I'm all for incremental complication.