This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [patch v4 11/24] record-btrace: supply register target methods
- From: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 23 Sep 2013 06:55:34 +0000
- Subject: RE: [patch v4 11/24] record-btrace: supply register target methods
- Authentication-results: sourceware.org; auth=none
- References: <1372842874-28951-1-git-send-email-markus dot t dot metzger at intel dot com> <1372842874-28951-12-git-send-email-markus dot t dot metzger at intel dot com> <20130818190727 dot GI24153 at host2 dot jankratochvil dot net> <A78C989F6D9628469189715575E55B230A9CE9AC at IRSMSX104 dot ger dot corp dot intel dot com> <20130922135527 dot GA19149 at host2 dot jankratochvil dot net>
> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Jan Kratochvil
> > > Here should be rather:
> > > gdb_assert (may_write_registers == 0);
> > >
> > > as target_store_registers() would not pass the call here otherwise.
> >
> > I took this from target_store_registers in target.c.
>
> But that is a different case. The case 'may_write_registers == 0' is always
> already caught by target_store_registers(). record_btrace_store_registers()
> gets called only by target_store_registers() which already verified the
> variable is not zero.
OK. Changed it.
Regards,
Markus.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052