This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/7] New function windows_init_abi


On 09/20/2013 03:47 AM, Yao Qi wrote:

> 2013-09-08  Yao Qi  <yao@codesourcery.com>
> 
> 	* amd64-windows-tdep.c (amd64_windows_init_abi): Don't call
> 	set_gdbarch_iterate_over_objfiles_in_search_order.  Call
> 	windows_init_abi instead.
> 	* i386-cygwin-tdep.c (i386_cygwin_init_abi): Don't call
> 	set_gdbarch_has_dos_based_file_system and
> 	set_gdbarch_iterate_over_objfiles_in_search_order.  Call
> 	windows_init_abi instead.
> 	* windows-tdep.c (windows_init_abi): New function.
> 	(windows_iterate_over_objfiles_in_search_order): Make it
> 	static.
> 	* windows-tdep.h (windows_init_abi): Declare.
> 	(windows_iterate_over_objfiles_in_search_order): Remove
> 	declaration.

This looks like a good idea on its own, and could go in independently
of the rest of the series.

arm-wince-pe.c:arm_wince_init_abi should call windows_init_abi too.
That fact that that doesn't call
set_gdbarch_iterate_over_objfiles_in_search_order today looks like
exactly the sort of issue that a patch like this one would prevent.

The patch looks OK to me with that change.

['set_solib_ops (gdbarch, &solib_target_so_ops)' should be able to
move to windows_init_abi too.]

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]