This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/7] New function windows_init_abi
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 01 Oct 2013 10:35:03 +0100
- Subject: Re: [PATCH 3/7] New function windows_init_abi
- Authentication-results: sourceware.org; auth=none
- References: <1378641807-24256-1-git-send-email-yao at codesourcery dot com> <1379645226-8719-1-git-send-email-yao at codesourcery dot com> <1379645226-8719-4-git-send-email-yao at codesourcery dot com> <5249C19D dot 6060601 at redhat dot com> <524A6FBF dot 2090901 at codesourcery dot com>
On 10/01/2013 07:46 AM, Yao Qi wrote:
> On 10/01/2013 02:23 AM, Pedro Alves wrote:
>> arm-wince-pe.c:arm_wince_init_abi should call windows_init_abi too.
>> That fact that that doesn't call
>> set_gdbarch_iterate_over_objfiles_in_search_order today looks like
>> exactly the sort of issue that a patch like this one would prevent.
>
> windows-tdep.o is not linked for arm-wince-pe target. In
> configure.target:
>
> arm*-wince-pe | arm*-*-mingw32ce*)
> # Target: ARM based machine running Windows CE (win32)
> gdb_target_obs="arm-tdep.o arm-wince-tdep.o"
> build_gdbserver=yes
>
> I am not sure the TIB stuff in windows-tdep.c can be applicable to ARM
> wince target. It was discussed in the review to the patch
>
> [RFC-v2] Add windows Thread Information Block
> https://sourceware.org/ml/gdb-patches/2009-07/msg00010.html
>
> windows-tdep.c looks quite target-independent, except some comments,
> in which "fs" and "gs" is mentioned. How about this patch below?
Yeah, %fs and %gs of course are only applicable to x86/amd64. I don't
recall if the TIB structure on x86 WinCE is the same as the x86 desktop
Windows , and/or whether the ARM/x86 WinCE versions have the same
layout (ISTR not), or even what's the story for the new ARM WinRT (which I'm
assuming will a GDB port to soon enough). In any case, it's windows_get_tlb_type
that will probably need to evolve and be moved to arch tdep files. Making all
the Windows builds link in windows-tdep.c is definitely the correct
thing to do.
> windows-tdep.o is linked in target arm*-wince-pe and
> arm*-*-mingw32ce*, supposing set_solib_ops has been moved to
> windows_init_abi.
>>
>> The patch looks OK to me with that change.
>>
>> ['set_solib_ops (gdbarch, &solib_target_so_ops)' should be able to
>> move to windows_init_abi too.]
>
> OK. I'll move it to windows_init_abi in the updated patch.
>
> - /* Shared library handling. */
Leave this one. "skip_trampoline_code" is also related to shared library
handling.
> - set_solib_ops (gdbarch, &solib_target_so_ops);
> set_gdbarch_skip_trampoline_code (gdbarch, arm_pe_skip_trampoline_code);
Otherwise OK.
Thanks!
--
Pedro Alves