This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Use FILENAME_CMP to compare filenames in compare_search_syms.


> > Indeed! I'm turning this fix into a 2-patch series:
> > 
> >   1. Delete search_symbols_equal
> > 
> >      This patch does not fix anything, other than removing the duplication.
> > 
> >      I pondered a bit over that change, thinking maybe we'd want
> >      to keep it, just because the arguments have the right type
> >      instead of "void *". In the end, I felt it was sufficiently
> >      localized that deleting was OK. Putting it back is easy,
> >      though, so whichever we want it shall be.
> 
> This is fine with me.
> 
> >         * symtab.c (compare_search_syms): Use FILENAME_CMP instead of
> >         strcmp to compare two symtab filenames.
> 
> This one looks obvious to me.

Thanks, Pedro. Both patches are now in.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]