This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Use FILENAME_CMP to compare filenames in compare_search_syms.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 2 Oct 2013 11:24:23 +0200
- Subject: Re: [RFA] Use FILENAME_CMP to compare filenames in compare_search_syms.
- Authentication-results: sourceware.org; auth=none
- References: <1380618427-27814-1-git-send-email-brobecker at adacore dot com> <524A9BCF dot 90502 at redhat dot com> <20131001123031 dot GF2840 at adacore dot com> <524AE6E9 dot 8030505 at redhat dot com>
> > Indeed! I'm turning this fix into a 2-patch series:
> >
> > 1. Delete search_symbols_equal
> >
> > This patch does not fix anything, other than removing the duplication.
> >
> > I pondered a bit over that change, thinking maybe we'd want
> > to keep it, just because the arguments have the right type
> > instead of "void *". In the end, I felt it was sufficiently
> > localized that deleting was OK. Putting it back is easy,
> > though, so whichever we want it shall be.
>
> This is fine with me.
>
> > * symtab.c (compare_search_syms): Use FILENAME_CMP instead of
> > strcmp to compare two symtab filenames.
>
> This one looks obvious to me.
Thanks, Pedro. Both patches are now in.
--
Joel