This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- From: Tom Tromey <tromey at redhat dot com>
- To: "Blanc\, Nicolas" <nicolas dot blanc at intel dot com>
- Cc: "gdb-patches\ at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 15 Oct 2013 07:54:06 -0600
- Subject: Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- Authentication-results: sourceware.org; auth=none
- References: <1381148820-21890-1-git-send-email-nicolas dot blanc at intel dot com> <1381148820-21890-4-git-send-email-nicolas dot blanc at intel dot com> <874n8o6f66 dot fsf at fleche dot redhat dot com> <388084C8C1E6A64FA36AD1D656E4856624373405 at IRSMSX106 dot ger dot corp dot intel dot com>
>>>>> "Nicolas" == Blanc, Nicolas <nicolas.blanc@intel.com> writes:
Nicolas> I rewrote add_target_section_of_objfile using add_target_sections. The
Nicolas> new code needs to construct on the heap a temporary array of target
Nicolas> sections for the sole purpose of
Nicolas> calling add_target_sections. This is not as neat as the original code
Nicolas> in my view. I would prefer moving add_target_sections_of_objfile to
Nicolas> exec.c. Would this be ok with you?
It's fine to just do whatever you think is cleanest and then say why in
the re-send. Thanks.
Tom