This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix REGISTRY cleanups
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
- Date: Mon, 28 Oct 2013 14:13:27 +0000
- Subject: Re: [PATCH] Fix REGISTRY cleanups
- Authentication-results: sourceware.org; auth=none
- References: <1382759328-23938-1-git-send-email-yao at codesourcery dot com> <20131028034520 dot GB3066 at adacore dot com> <526E4C32 dot 7080601 at redhat dot com> <526E599D dot 8020902 at codesourcery dot com>
On 10/28/2013 12:33 PM, Yao Qi wrote:
> On 10/28/2013 07:36 PM, Pedro Alves wrote:
>> (Yao, FYI, "fix" in the subject line confused me a little,
>> as I found myself scratching my head a little trying to understand
>> what bug this actually fixes, only to realize it's a code
>> cleanup sort of fix. I'd suggest changing the subject/commit
>> to reflect that.)
>
> How about "Simplify REGISTRY cleanup usages"? I also update the
> comments in registry.h to document the arguments of FREE function.
Looks good to me.
Thanks,
--
Pedro Alves