This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 1/6 -V2] Fix display of tabulation character for mingw hosts.
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Keith Seitz'" <keiths at redhat dot com>, "'gdb-patches'" <gdb-patches at sourceware dot org>
- Date: Wed, 06 Nov 2013 14:16:18 -0700
- Subject: Re: [RFC 1/6 -V2] Fix display of tabulation character for mingw hosts.
- Authentication-results: sourceware.org; auth=none
- References: <002901cebaf2$35ec65a0$a1c530e0$ at muller@ics-cnrs.unistra.fr> <002c01cebaf2$89798ea0$9c6cabe0$ at muller@ics-cnrs.unistra.fr> <524A230B dot 5020304 at redhat dot com> <10182 dot 1932978512$1380614580 at news dot gmane dot org>
>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:
Pierre> 2013-10-01 Pierre Muller <muller@sourceware.org>
Pierre> Fix display of tabulation character for MinGW hosts.
Pierre> * gdb_wchar.h (gdb_iswprint): Declare as external function
Pierre> if __MINGW32__ macro is set.
Pierre> (HAVE_MINGW_GDB_ISWPRINT): New macro, declared only for
Pierre> MinGW hosts using wide characters.
Pierre> * mingw-hdep.c (gdb_iswprint): New function.
Pierre> Implemented only if HAVE_MINGW_GDB_ISWPRINT macro is defined.
If this is just for working around one mingw bug in one spot in gdb, I
think on the whole it would be simpler to just check for \t directly in
print_wchar. I think with a short comment it will be simpler in the end
than a new macro and a new host-specific function.
Tom