This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch][python] 2/3 Python representation of GDB line tables (Testsuite)
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 07 Nov 2013 15:43:07 +0000
- Subject: Re: [patch][python] 2/3 Python representation of GDB line tables (Testsuite)
- Authentication-results: sourceware.org; auth=none
- References: <5253F4DD dot 4000104 at redhat dot com> <87k3h3d802 dot fsf at fleche dot redhat dot com>
On 23/10/13 21:53, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> This patch in the series contains the testsuite code for Python
> Phil> linetables.
>
> Phil> diff --git a/gdb/testsuite/gdb.python/py-linetable.S
> Phil> b/gdb/testsuite/gdb.python/py-linetable.S
> Phil> new file mode 100644
> Phil> index 0000000..5957222
> Phil> --- /dev/null
> Phil> +++ b/gdb/testsuite/gdb.python/py-linetable.S
> Phil> @@ -0,0 +1,345 @@
> Phil> + .file "py-linetable.c"
> Phil> + .text
> Phil> +.Ltext0:
>
> Normally we hack in a comment header at the top.
>
> I wonder whether assembly is truly needed in this case.
It was included at Jan's suggestion. To ensure compatibility between
compiler versions. However, the test is compiled unoptimized so I
suspect the potential of change in the linetable between versions is
slim. I have no strong opinion. What do you think?
>
> Phil> +#
> Phil> +# You should have received a copy of the GNU General Public License
> Phil> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> Phil> +load_lib gdb-python.exp
> Phil> +set opts {}
> Phil> +standard_testfile .S
>
> Blank line between comments and code.
>
> Phil> +gdb_py_test_silent_cmd "python lt =
> Phil> gdb.selected_frame().find_sal().symtab.linetable()" \
>
> Your patch got wrapped.
No idea how this happened. It was produced by git format-patch, and
the file inserted into the email (IE, not copy and pasted). So that
was weird.
Regards
Phil