This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb-patches at sourceware dot org, pmuldoon at redhat dot com, eliz at gnu dot org
- Date: Thu, 14 Nov 2013 18:30:56 +0000
- Subject: Re: [PATCH, doc RFA] Allow CLI and Python conditions to be set on same breakpoint
- Authentication-results: sourceware.org; auth=none
- References: <m3siv0q29h dot fsf at seba dot sebabeach dot org> <m3k3gaq3gw dot fsf at seba dot sebabeach dot org>
On 11/14/2013 05:48 PM, Doug Evans wrote:
> Regression tested on amd64-linux.
>
> Ok to check in?
>
This is fine with me.
> - if (cond && b->disposition != disp_del_at_next_stop)
> + if (cli_cond && b->disposition != disp_del_at_next_stop)
(BTW, I notice that the 'b->disposition != disp_del_at_next_stop'
handling in this function looks suspicious.)
> if (within_current_scope)
> - value_is_zero
> - = catch_errors (breakpoint_cond_eval, cond,
> + {
> + int cond_result =
= goes on the next line.
--
Pedro Alves