This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: walfred dot tedeschi at intel dot com
- Cc: palves at redhat dot com, yao at codesourcery dot com, gdb-patches at sourceware dot org, walfred dot tedeschi at intel dot com
- Date: Mon, 25 Nov 2013 15:49:06 +0100 (CET)
- Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- Authentication-results: sourceware.org; auth=none
- References: <1385386802-16948-1-git-send-email-walfred dot tedeschi at intel dot com>
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:40:02 +0100
>
> Macro returning the size of the xsave buffer got broken with the MPX
> patch. Fix improves the macro to make it more readable.
>
> 2013-12-25 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> * i386-xstate.h (I386_XSTATE_MPX): New Macro.
> (I386_XSTATE_MPX_MASK): Makes use of I386_XSTATE_MPX.
> (HAS_MPX): New macro.
> (HAS_AVX): New macro.
> (I386_XSTATE_SIZE): Refactored macro using HAS_MPX and
> HAS_AVX.
> ---
> gdb/common/i386-xstate.h | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> +/* In case one of the MPX XCR0 bits is set we consider we have MPX. */
> +#define HAS_MPX(XCR0) (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDREGS) \
> + || (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDCFG)
That doesn't seem to do what it says on the tin!